Re: [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

Dear Chris Packham,

In message 20170104003626.4211-2-judge.packham@gmail.com you wrote:

Ensure '.' is used to separate octets. If another character is seen reject the string outright and return 0.0.0.0.

What is this good for?

The old code was forgiving and would accept 192,168,1,2 as well. Do we need to be so strict here - at the cost of added code size?

Also, at least crtitical parts of the network code (NFS, TFTP) do not check the return value of string_to_ip() - so what is the benefit of this change?

Best regards,

Wolfgang Denk