Hiremath, Vaibhav wrote:
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Tuesday, November 24, 2009 1:21 AM To: Hiremath, Vaibhav Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4
Dear hvaibhav@ti.com,
In message 1258974555-28173-1-git-send-email-hvaibhav@ti.com you wrote:
From: Vaibhav Hiremath hvaibhav@ti.com
Changes:-
- Created 2 seperate config option
- CONFIG_SDRC (omap34xx family)
- CONFIG_EMIF4 (am3517 family)
- Changed all omap3 dependent file for CONFIG_SDRC
Tested On:-
- AM3517EVM board - OMAP3EVM board - BEAGLE boardI would need help here from people to validate this change for
SDP/ZOOMx
and other OMAP3 version of boards.
This commit adds a lot of #ifdef's - maybe it would make more sense to split code into different files?
[Hiremath, Vaibhav] Initially I thought of this, but since currently AM3517 is the only device in OMAP3 series which uses EMIF and all others use SDRC. So I thought lets start with this approach and get peoples opinion on this, and then we can split the files.
Please split this patch. Add the logic for the exiting boards as the first patch. Add the logic for the am3517 as the second. This will allow this change to be bisected.
I would prefer each set of defines to have their own file.
Tom
Thanks, Vaibhav
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de You are an excellent tactician, Captain. You let your second in com- mand attack while you sit and watch for weakness. -- Khan Noonian Singh, "Space Seed", stardate 3141.9
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot