On Thu, 2018-03-08 at 14:04 -0700, Simon Glass wrote:
Hi,
On 7 March 2018 at 22:03, Chee, Tien Fong tien.fong.chee@intel.com wrote:
On Tue, 2018-03-06 at 10:51 -0700, Simon Glass wrote:
Hi,
On 5 March 2018 at 02:43, tien.fong.chee@intel.com wrote:
From: Tien Fong Chee tien.fong.chee@intel.com
This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie. the FPGA device.
Signed-off-by: Tien Fong Chee tien.fong.chee@intel.com Reviewed-by: Lothar Waßmann LW@KARO-electronics.de
common/Kconfig | 10 ++ common/Makefile | 1 + common/fs_loader.c | 353 +++++++++++++++++++++++++++++++++++++++++++++ doc/README.firmware_loader | 86 +++++++++++ include/fs_loader.h | 28 ++++ 5 files changed, 478 insertions(+) create mode 100644 common/fs_loader.c create mode 100644 doc/README.firmware_loader create mode 100644 include/fs_loader.h
This looks fine as a concept but I am not keen on the implementation.
This patchset has been going through many rounds and a lot of time spending in review, and it is already working and being tested. I still have a lot subsequent patches pending on this patchset. I would suggest to accept this patchset, then we can enhance it to driver model in later.
- It should use driver model (only) in U-Boot proper. If there
is some SPL problem then add a specific function or feature for SPL.
We can doing this in later since it is require sometime to figure out and testing.
- It should not be necessary ti manually init subsystems -
driver model does this for you
This is for initializing storage driver in very early SPL, where loading from storage to configure some critical HW need to done first.
- You can use the uclass name to find things
Yeah, once it is converted to driver model, we can use the uclass for searching HW info in DTS.
Please let me know if you need more info.
Well I'm still not keen on this. Are you planning to do the conversion? It seems like a lot of work for someone else to do.
Okay, i will try to convert it into driver model.
Regards, Simon