On Dec 2, 2013, at 10:49 PM, Masahiro Yamada wrote:
Hello York.
And it also looks weird to me.
Why did you put this code in arch/powerpc/cpu/mpc83xx/Makefie, not drivers/ddr/fsl/Makefile ?
I understand this looks weird. Most 83xx didn't use the same driver as 85xx SoCs do. Freescale DDR driver has two parts. One is the calculation. This can be shared by all families. The other, smaller, is the writing registers part. Each family has its own driver. You may have noticed one for 85xx, and one for 86xx. We could create one for 83xx. But till now, there is no other 83xx SoC uses it.
After this patch set, we have consolidated Freescale DDR drivers and header files into one set. It becomes more clear that we can and probably should merge this one as well. It's on my list to clean up, but this one has low priority.
Hope I explained it clearly.
OK. This refactoring is up to you. But, anyway, we can't use absolute paths for obj-y.
So, I posted a patch: http://patchwork.ozlabs.org/patch/296086/
Thanks for the patch. I am not against either way. I noticed the path for out of tree compiling and I didn't see which one is better. I found examples of both. I personally think using $(SRCTREE) is cleaner. Let's wait for others to chime in.
York