Re: [PATCH 1/3] binman: Allow to define custom arguments

On 12.06.23 23:17, Simon Glass wrote:

Hi Jan,

On Mon, 5 Jun 2023 at 15:39, Jan Kiszka jan.kiszka@siemens.com wrote:

...

From: Jan Kiszka jan.kiszka@siemens.com

Introduce BINMAN_EXTRA_ARGS that can be set per board, e.g., to inject specific settings. Will be used by IOT2050 first to define multiple of-lists.

Signed-off-by: Jan Kiszka jan.kiszka@siemens.com

CC: Simon Glass sjg@chromium.org

Makefile | 1 + 1 file changed, 1 insertion(+)

I'm really not keen on this, since it means that the Makefile (or some vars it sets) are again involved in controlling the image generation. It should really all be in the binman image description / .dtsi file

binman does not allow me to unrole of-list inside the dts file, does it? With such a feature, I wouldn't need any custom -a of-list-X switches and, thus, no such EXTRA_ARGS.

Jan