Dear Rajeshwari Shinde,
On 4 May 2012 20:12, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:
This patch adds a function to set usb host mode to USB 2.0 HOST Link for EXYNOS5
Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
need the change log here. http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
This patchset is based on: USB: EXYNOS: Add ehci support.patch
arch/arm/cpu/armv7/exynos/system.c | 22 ++++++++++++++++++++++ arch/arm/include/asm/arch-exynos/system.h | 3 +++ drivers/usb/host/ehci-exynos.c | 3 +++ 3 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c index 6c34730..7ff4e09 100644 --- a/arch/arm/cpu/armv7/exynos/system.c +++ b/arch/arm/cpu/armv7/exynos/system.c @@ -46,3 +46,25 @@ void set_system_display_ctrl(void) if (cpu_is_exynos4()) exynos4_set_system_display(); }
+static void exynos5_enable_usbhost_mode(unsigned int mode)
Please move this function to up the set_system_display_ctrl function. APIs should be gathered to bottom of file.
+{
- struct exynos5_sysreg *sysreg =
- (struct exynos5_sysreg *)samsung_get_base_sysreg();
- unsigned int phy_cfg;
- /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
- if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
- setbits_le32(&sysreg->usb20phy_cfg,
- USB20_PHY_CFG_HOST_LINK_EN);
- } else {
- clrbits_le32(&sysreg->usb20phy_cfg,
- USB20_PHY_CFG_HOST_LINK_EN);
- }
+}
+void enable_usbhost_mode(unsigned int mode)
API's name should be set_* or get_*. Please fix it.
+{
- if (cpu_is_exynos5())
- exynos5_enable_usbhost_mode(mode);
+}
Thanks. Minkyu Kang.