Hi Tom,
I have reply the review tag to the list last week, but this mail does not appear at the patchwork system[1],
did you met this kind of issue and do you know how to fix it?
Thanks,
- Kever
[1] https://patchwork.ozlabs.org/project/uboot/patch/GV1PR08MB801036B040F257C97C...
On 2023/7/21 17:05, Kever Yang wrote:
On 2023/7/15 18:19, Pegorer Massimo wrote:
Definition of function board_debug_uart_init() must be under CONFIG_DEBUG_UART_BOARD_INIT and not under CONFIG_DEBUG_UART, as it was: see debug_uart.h. In this way the debug uart can be used but its board-specific initialization skipped by configuration, if useless.
Signed-off-by: Massimo Pegorer massimo.pegorer@vimar.com
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks,
- Kever
arch/arm/mach-rockchip/rk3308/rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/rk3308/rk3308.c b/arch/arm/mach-rockchip/rk3308/rk3308.c index dd9109b7c3..5763604dc3 100644 --- a/arch/arm/mach-rockchip/rk3308/rk3308.c +++ b/arch/arm/mach-rockchip/rk3308/rk3308.c @@ -174,7 +174,7 @@ int rk_board_init(void) return 0; } -#if defined(CONFIG_DEBUG_UART) +#ifdef CONFIG_DEBUG_UART_BOARD_INIT __weak void board_debug_uart_init(void) { static struct rk3308_grf * const grf = (void *)GRF_BASE;