Hi Prafulla,
On Thu, 2010-06-24 at 13:22 +0200, Prafulla Wadaskar wrote:
-----Original Message----- From: Tor Krill [mailto:tor@excito.com] Sent: Thursday, June 24, 2010 3:02 PM To: u-boot@lists.denx.de Cc: Prafulla Wadaskar; Tor Krill Subject: [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.
Changing its configuration from PHY_BASE_ADR single value to use CONFIG_PHY_BASE_ADDRS as an array with adresses.
Updated in version 2:
Merged board updates to single patch.
These two lines should go as changelog for v2 below (after ---)
Sorry, there seems to be no end on my mistakes :(
Signed-off-by: Tor Krill tor@excito.com
i.e. here..
board/keymile/km_arm/km_arm.c | 3 ++- drivers/net/kirkwood_egiga.c | 3 ++- drivers/net/kirkwood_egiga.h | 8 ++++---- include/configs/guruplug.h | 2 +- include/configs/km_arm.h | 2 +- include/configs/openrd_base.h | 2 +- include/configs/rd6281a.h | 2 +- include/configs/sheevaplug.h | 2 +- 8 files changed, 13 insertions(+), 11 deletions(-)
Hi Tom I understood your problem. But all of the Kirkwood boards so far have similar implementation which is standard practice. How does your board design differed in this case?
Instead of fixing it here for all other boards, can't you simply align PHY address on your board? I think this will be much easier.
We use both ethernet interfaces by default in our design, with the phy addresses 0x08 and 0x18, and unfortunately we have already started the manufacturing of these units which makes it expensive and hard to reverse this design decision :(
But if we turn this around if the hardware allows this then why not let this be configurable in u-boot as well? Do this have any technical implications on the other boards?
Best Regards,
/Tor