On 10/24/2016 11:55 PM, Prabhakar Kushwaha wrote:
-----Original Message----- From: york sun Sent: Monday, October 24, 2016 9:41 PM To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; u- boot@lists.denx.de Cc: oss@buserror.net Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h
On 10/23/2016 07:04 AM, Prabhakar Kushwaha wrote:
Hi York,
-----Original Message----- From: york sun Sent: Friday, October 21, 2016 7:55 PM To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; u- boot@lists.denx.de Cc: oss@buserror.net Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h
On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding SoC name in Kconfig as Dependencies. It will help in having all SoC related defines in config.h - easy to maintain.
Prabhakar,
Why do you want to go back to config.h? I think we are going with Kconfig. Having everything in one config file conflicts with Kconfig. The former has centralized config per SoC, the latter has centralized config per feature.
There are 2 reason for this
- in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will keep
on increasing with SoC.
And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be
done and it will also keep on increasing with SoC.
I want to avoid it.
config SYS_FSL_IFC_BANK_COUNT int "Maximum banks of Integrated flash controller" depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A
The "depends" line can be rewritten with HAS_* feature macro.
default 4 if ARCH_LS1043A default 4 if ARCH_LS1046A default 8 if ARCH_LS2080A
You can simplify the "default 4" for all and only use different number for others.
ok
- There is no file similar to " arch/arm/cpu/armv8/fsl-layerscape/Kconfig" for
powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with different values per SoC.
This problem will come for defining other clocks for " armv8/fsl-lsch3:
consolidate the clock system initialization"
We will convert powerpc as well.
This means, IFC and clock related patches needs to wait till powerpc is converted as well.
Maybe. If you have bandwidth, you can take it. Or you can wait for me to get it done. My plate is full, so it will take a while before I start.
York