On Mon, 2009-07-20 at 17:40 +0200, Thomas Petazzoni wrote:
Le Thu, 16 Jul 2009 09:52:43 -0500, Peter Tyser ptyser@xes-inc.com a écrit :
I don't have the final say here, I'm just giving my opinion. If it was possible to clean up, the best way in my would be to fix your board (ie this patch), then send a separate follow-up patch fixing other boards. I don't think its too big of a deal either way.
Including <common.h> in a include/configs/ configuration file doesn't seem to work, unfortunately.
There might be other ways, eg it looks like Wolfgang addressed the issue in this patch: http://www.mail-archive.com/u-boot@lists.denx.de/msg17937.html
Does that patch work for you? I'm assuming it will go in the next U-Boot release.
+######################################################################### diff --git a/board/calao/usb-a9263/config.mk b/board/calao/usb-a9263/config.mk new file mode 100644 index 0000000..ff2cfd1 --- /dev/null +++ b/board/calao/usb-a9263/config.mk @@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
You should add a copyright header of some sort to config.mk.
In a one-line file, which just contains a factual definition ?
In my opinion yes. A copyright will explicitly say how the file may be used, trivial as it may be. Check out doc/feature-removal-schedule.txt:
What: GPL cleanup When: August 2009 Why: Over time, a couple of files have sneaked in into the U-Boot source code that are either missing a valid GPL license header or that carry a license that is incompatible with the GPL. Such files shall be removed from the U-Boot source tree. See http://www.denx.de/wiki/pub/U-Boot/TaskGplCleanup/u-boot-1.1.2-files for an old and probably incomplete list of such files.
You're free to use whatever license you'd like, as long as its GPL compatible. There's no harm in adding a license header, right?
Best, Peter