Hey Simon,
On Sun, 2015-08-23 at 15:23 -0600, Simon Glass wrote:
Hi Sjoerd,
Tested on a Radxa Rock 2 with square baseboard, booting from SD card. I haven't tested eMMC yet however i suspect the SPL will need modifications there to load u-boot from eMMC rather then SD (which has index 0) ideally by detecting where the SPL itself got loaded from.
This series works well for me. I'm hoping to be able to resend my rockchip series at the end of this coming week and potentially apply it the week after. Since your series fixes up the Rockchip to actually boot a kernel I'd like to bring this in also.
That's great to hear.
I'll reply to each patch - mostly I just have nits so I have acked those where I don't have significant comments.
Cool, I'll see if have some time to tweak those nits this week, most seem quite small :). Would be great to see rockchip support land upstream, I was wondering what was going on there as it seemed stuck for a while.
Just for reference, i've got a work-in-progress follow-up set of patches in the making which add ethernet support (should work on firefly, but only tested on my Radxa board). Still needs a good amount of cleanups though before i can submit it:
FYI: https://git.collabora.com/cgit/user/sjoerd/u-boot.git/log/?h=master%2brockch...
Sjoerd Simons (8): doc: Fix reference to Rock pro when Rock 2 is meant mmc: Probe DM based mmc devices in u-boot rockchip: Disable sdio mmc slot on rk3288-firefly rockchip: Turn off CONFIG_SPL_LED_SUPPORT for firefly rockchip: Add config_distro_bootcmd support arm: Turn of d-cache before i-cache rockchip: Drop first 32kb of zeros from the rksd image type rockchip: Update todo in README.rockchip
arch/arm/cpu/armv7/cpu.c | 15 +++++++++------ arch/arm/dts/rk3288-firefly.dtsi | 2 +- doc/README.rockchip | 9 ++++----- drivers/mmc/mmc.c | 32 ++++++++++++++++++++++++++++
include/configs/firefly-rk3288.h | 1 - include/configs/rk3288_common.h | 21 +++++++++++++++++++++ tools/rksd.c | 9 ++------- 7 files changed, 65 insertions(+), 24 deletions(-)
-- 2.5.0
Regards, Simon