On 03/14/2014 02:15 PM, Simon Glass wrote:
Hi Stephen,
On 13 March 2014 11:42, Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
Clean up the naming of pinmux-related objects:
- Refer to drive groups rather than pad groups to match the Linux kernel.
- Ensure all pinmux API types are prefixed with pmux_, values (defines) are prefixed with PMUX_, and functions prefixed with pinmux_.
- Modify a few type names to make their content clearer.
- Minimal changes to SoC-specific .h/.c files are made so the code still compiles. A separate per-SoC change will be made immediately following, in order to keep individual patch size down.
Signed-off-by: Stephen Warren swarren@nvidia.com
Acked-by: Simon Glass sjg@chromium.org
A few comments below.
diff --git a/arch/arm/cpu/tegra114-common/pinmux.c b/arch/arm/cpu/tegra114-common/pinmux.c index af8b7ca5fc79..efe5163084c1 100644 --- a/arch/arm/cpu/tegra114-common/pinmux.c +++ b/arch/arm/cpu/tegra114-common/pinmux.c @@ -41,7 +41,7 @@ #define PIN_RESERVED \ PIN(NONE, NONE, INVALID, INVALID, INVALID, INVALID, NONE)
-const struct tegra_pingroup_desc tegra114_pingroups[PINGRP_COUNT] = { +const struct pmux_pingrp_desc tegra114_pingroups[PMUX_PINGRP_COUNT] = {
Can some of these be static?
Yes. I'll actually fix this in patch 5, since that patch is what introduced:
const struct tegra_pingroup_desc *tegra_soc_pingroups \ = tegra114_pingroups;
... which is what allows this table to be static.