Dear Albert,
In message 20150701234229.705fe4ce@lilith you wrote:
On Thu, 16 Apr 2015 11:21:44 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello Masahiro,
Your patch clashes with Pavel's already committed break-if-private-libgcc-and-thumb, causing many boards to fail building.
I am putting your patch in 'under review' state until I can have a look at what happens with private libgcc and thumb.
Hmm, even with the libgcc+thumb thing fixed, this patch still causes quite a few target to fail:
- without the patch, buildman yields 503 1 12 / 516.
- With the patch, buildman yields 488 1 27 / 516.
Of these, 10 are aarch64 boards which now try to build a private libgcc with some hardwired 32-bit mnemonics :
Actually I think it is inherently wrong to enable CONFIG_USE_PRIVATE_LIBGCC by default.
This option is intended as a workaround for broken toolchains, until these get fixed. By enabling this by default, we miss do not notice the problems our tool chain has, and therefore these never get fixed, i. e. brokenness grows. This cannot be good.
CONFIG_USE_PRIVATE_LIBGCC should only be an emergency-opt-in, but never ever a default setting.
Best regards,
Wolfgang Denk