23 Nov
2006
23 Nov
'06
11:35 a.m.
On Thursday 23 November 2006 09:06, Matvejchikov Ilya wrote:
2006/11/22, Stefan Roese sr@denx.de:
Some comments:
- Are you sure that you can't use the common CFI FLASH driver?
No, I'am not sure about it. Is it so important?
Yes. Most of the board specific FLASH driver are error prone, since the code and it's error are copied over and over again. This is not maintainable. The CFI driver has a very broad test basis and is maintained quite good.
And a new board port with a board specific flash driver that is not needed, meaning when CFI compliant FLASH chips are used, will not be accepted anymore.
What FLASH chips are you using?
- Please don't use C++ style comments.
- Use tabs for indentation (for example in board/mc68360/mc68360.c).
- Please rework your board config file. There is no comment at all so this is not readable.
ok
Thanks.
Best regards, Stefan