Hi Wolfgang,
On 11/28/11 10:07, Wolfgang Denk wrote:
Dear Igor Grinberg,
In message 1322467058-30532-1-git-send-email-grinberg@compulab.co.il you wrote:
When ENV_IS_EMBEDDED is not set, but CONFIG_BUILD_ENVCRC is set, the environment.h file does not get included resulting in unrecognized env_t type. Fix this by moving the include directive.
Hm... the fix seems wrong to me. What happens now if ENV_IS_EMBEDDED is set, but CONFIG_BUILD_ENVCRC is _not_ set?
Well, you should look into that file... it says: #if defined(ENV_IS_EMBEDDED) && !defined(CONFIG_BUILD_ENVCRC) # define CONFIG_BUILD_ENVCRC 1 #endif
So this will not be a problem. As for the logic of it... I don't know what was the original intend.
Did this change pass a MAKEALL for example for ppc?
I don't have the tool chain for ppc. I think the original fix has been tested by Stefano. Is there a requirement to have all the supported architectures tool chains, for submitting patches?
Stefano, Mike, can you, please, test it on PPC and Blackfin?
Thanks