Simon,
This was only tested with the new RK3399 HDMI support in place. There’s a missing #include in the original rk_hdmi.c (before I submitted my patches for HDMI), which causes these functions to not be defined.
What’s the preferred way that you’d like this resolved: (a) wait until the HDMI-changes (in Anatolij’s tree) are merged to master, before applying this patch? (b) fix the issue in the older rk_hdmi.c (which doesn’t really have RK3399 support anyway) and deal with the conflict when the changeset from Anatolij’s tree trickled back down into the rockchip tree?
Thanks, Philipp.
On 05 Jun 2017, at 23:33, Simon Glass sjg@chromium.org wrote:
Hi Phlilpp,
On 1 June 2017 at 20:55, Simon Glass sjg@chromium.org wrote:
On 31 May 2017 at 10:18, Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
With HDMI output for the RK3399 working, this update the RK3399-Q7 (Puma) defconfig for the new functionality:
- enables PMIC command (to check if the HDMI voltages are correct) +CONFIG_CMD_PMIC=y +CONFIG_CMD_REGULATOR=y
- enables video-output (via HDMI) +CONFIG_DM_VIDEO=y +CONFIG_DISPLAY=y +CONFIG_VIDEO_ROCKCHIP=y +CONFIG_DISPLAY_ROCKCHIP_HDMI=y
- turns on the 'dcache'-command (for a dcache flush) for our QA to
fill the framebuffer using 'mw.l' +CONFIG_CMD_CACHE=y 4. turns on the 'bmp'-command +CONFIG_CMD_BMP=y
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Changes in v2:
- enable CMD_BMP in the puma-rk3399_defconfig (following a rebase to
the upstream master after CMD_BMP was migrate to Kconfig)
configs/puma-rk3399_defconfig | 8 ++++++++ 1 file changed, 8 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Sadly another build error:
+drivers/video/rockchip/rk_hdmi.c:150: undefined reference to `rk_setreg' +drivers/video/rockchip/rk_hdmi.c:153: undefined reference to `rk_clrsetreg'