On Sun, 07 Jul 2013 14:48:18 +0900, Minkyu Kang wrote:
Dear Minkyu,
Dear Lukasz,
On 4 July 2013 19:52, Lukasz Majewski l.majewski@samsung.com wrote:
From: Arkadiusz Wlodarczyk a.wlodarczyk@samsung.com
Proper adjustment for supporting DFU at GONI target has been made. The s5p_goni.h file has been updated. Moreover the code for low level USB initialization has been added to GONI board code.
Signed-off-by: Arkadiusz Wlodarczyk a.wlodarczyk@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com Tested-by: Arkadiusz Wlodarczyk a.wlodarczyk@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com
Please add change log here. And this patch seem version 3 (or 2?), but you did not mention it.
To be honest it is RESEND to v2 of this patch. Since v2 didn't applied to u-boot-samsung/master branch.
Why I did resend? You have only replied on the PATCH 2/4 and I thought that other patches are still under review. I didn't want to send v3 over patches which might be under review.
board/samsung/goni/goni.c | 7 +++++++ include/configs/s5p_goni.h | 20 +++++++++++++++++++- 2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c index ff76963..3c53106 100644 --- a/board/samsung/goni/goni.c +++ b/board/samsung/goni/goni.c @@ -155,4 +155,11 @@ struct s3c_plat_otg_data s5pc110_otg_data = { .regs_otg = S5PC110_OTG_BASE, .usb_phy_ctrl = S5PC110_USB_PHY_CONTROL, };
+void board_usb_init(void) +{
debug("USB_udc_probe\n");s3c_udc_probe(&s5pc110_otg_data);+}
#endif diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h index ec43652..8a824c7 100644 --- a/include/configs/s5p_goni.h +++ b/include/configs/s5p_goni.h @@ -86,6 +86,17 @@ #define CONFIG_CMD_ONENAND #define CONFIG_CMD_MTDPARTS #define CONFIG_CMD_MMC +#define CONFIG_CMD_DFU
+/* USB Composite download gadget - g_dnl */ +#define CONFIG_USBDOWNLOAD_GADGET +#define CONFIG_DFU_FUNCTION +#define CONFIG_DFU_MMC
+/* USB Samsung's IDs */ +#define CONFIG_G_DNL_VENDOR_NUM 0x04E8 +#define CONFIG_G_DNL_PRODUCT_NUM 0x6601 +#define CONFIG_G_DNL_MANUFACTURER "Samsung"
#define CONFIG_BOOTDELAY 1 #define CONFIG_ZERO_BOOTDELAY_CHECK @@ -105,6 +116,10 @@ ",60m(qboot)"\ ",-(UBI)\0"
+#define CONFIG_DFU_ALT \
"u-boot mmc 80 400;" \"uImage fat 0 2\0" \#define NORMAL_MTDPARTS_DEFAULT MTDPARTS_DEFAULT
#define CONFIG_BOOTCOMMAND "run mmcboot" @@ -175,7 +190,9 @@ "bootblock=9\0" \ "ubiblock=8\0" \ "ubi=enabled\0" \
"opts=always_resume=1"
"opts=always_resume=1\0" \"dfu_alt_info=" CONFIG_DFU_ALTseems redundant blank line.
Ok.
/* Miscellaneous configurable options */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ @@ -242,5 +259,6 @@ #define CONFIG_USB_GADGET #define CONFIG_USB_GADGET_S3C_UDC_OTG #define CONFIG_USB_GADGET_DUALSPEED +#define CONFIG_USB_GADGET_VBUS_DRAW 2
#endif /* __CONFIG_H */
1.7.10.4
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Thanks, Minkyu Kang.