On Monday, March 30, 2015 at 03:36:29 PM, Paul Kocialkowski wrote:
Le lundi 30 mars 2015 à 10:06 +0200, Lukasz Majewski a écrit :
Hi Paul,
Signed-off-by: Paul Kocialkowski contact@paulk.fr
common/usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/usb.c b/common/usb.c index 32e15cd..ea5b406 100644 --- a/common/usb.c +++ b/common/usb.c @@ -915,7 +915,7 @@ int usb_new_device(struct usb_device *dev)
if (err < 8) {
printf("\n USB device not responding, " \"giving up (status=%lX)\n", dev->status);
return 1;
return -1;If you are going to provide consistency with error codes, then I think that it would be beneficial to return -Exxx codes (like -EINVAL, etc).
That makes sense, I'll give it a try soon (I'm not sure I'll get all the appropriate error codes right at first try though).
I agree, using proper errno is a step in the right direction. Thanks!
Best regards, Marek Vasut