Hi Scott
I have already posted v2 patch for this change which has only cosmetic change suggested by you. Ref : http://lists.denx.de/pipermail/u-boot/2009-May/053485.html
Since Kirkwood Basic Soc support is pulled in, and if there are no issues pending with this driver. May I request you to pull this on nand/next? Followed by pull request to Wolfgang.
Regards.. Prafulla . .
-----Original Message----- From: Scott Wood [mailto:scottwood@freescale.com] Sent: Saturday, May 30, 2009 1:10 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek Subject: Re: [U-Boot] [PATCH] nand: Add Marvell Kirkwood NAND driver
On Sat, May 30, 2009 at 01:13:34AM +0530, Prafulla Wadaskar wrote:
This patch adds a NAND driver for the Marvell Kirkwood SoC's.
Acked-by: Stefan Roese sr@denx.de Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
ACK, except for a typo:
+/* NAND Flash Soc registers */ +struct kwnandf_registers {
- u32 rd_params; /* 0x10418 */
- u32 wr_param; /* 0x1041c */
- u8 pag[0x10470 - 0x1041c -4];
s/pag/pad/, presumably. Also s/-4/- 4/.
-Scott