On Saturday 11 August 2012 16:05:36 Benoît Thébaudeau wrote:
On 08/11/2012 21:47, Andrew Dyer wrote:
I agree with Mike, use the current dcache settings. U-boot has always assumed the user knew what they were doing. If you want to print a small message with the dcache setting that makes sense to me, but no big warning.
Then, something like the following at runtime in the first lines printed my mtest?
dcache state: on
i'd be fine with that. something like below (if you want to test & post, that'd be good). -mike
diff --git a/common/cmd_mem.c b/common/cmd_mem.c index 18f0a3f..5628f6a 100644 --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -651,8 +651,10 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) else iteration_limit = 0;
+ printf("Testing %08x ... %08x (dcache: %s):\n", (uint)start, (uint)end, + dcache_status() ? "on" : "off"); + #if defined(CONFIG_SYS_ALT_MEMTEST) - printf ("Testing %08x ... %08x:\n", (uint)start, (uint)end); debug("%s:%d: start 0x%p end 0x%p\n", __FUNCTION__, __LINE__, start, end);