On 12/07/2012 10:11 AM, Vipin Kumar wrote:
I'm not so sure about the name of this "driver" and its location in drivers/misc. Is "C3" a generic crypto IP name? On which devices/SoC's is it currently implemented? Perhaps the name should be a little less
It is an ST peripheral and is used in spear SoCs and could be used in other ST SoCs
generic, e.g. "spear-c3" or "st-crypto-c3"...?
hmm, ok. I can rename it to st-crypto-c3
Okay.
And if this "driver" only supports this memory fill operation for some ST SoC (SPEAr?), then its perhaps better located in arch/arm/ right now. Not sure.
You mean arch/arm/cpu/armv7/spear13xx/ ?
Or perhaps arch/arm/lib?
On powerpc we have a special SoC specific memcpy version as well. You might want to take a look at it:
arch/powerpc/lib/memcpy_mpc5200.c
It doesn't use a special device for transfer though, only has some alignment restrictions.
Is the drivers/misc a special place. Why not here ?
From my understanding the C3 "driver" you implemented with this memset()
is not a "real" *driver*. Thats my main reasoning why its a bit misplaced in "drivers/*".
But I have no strong feelings here. Perhaps others have thought/ideas/comments as well. Let's wait for further input a bit...
Thanks, Stefan