Hi Simon,
On Mon, 28 Jul 2014 04:43:35 +0100 Simon Glass sjg@chromium.org wrote:
Also some thoughts for the future:
- The 'menuconfig' option makes it obvious that we are dealing with
U-Boot / SPL / TPL. Can we do the same for 'xconfig'?
Sorry, I could not understand what you mean.
In my rough understanding, 'menuconfig' and 'xconfig' are equivalent except the appearance of GUI.
What is expactly supported in 'menuconfig' and missing in 'xconfig'?
- If I do 'make tpl/menuconfig' and there is no TPL defined, I wonder
if it should give an error rather than allowing you to edit it?
I am not sure if it should. Anyway I can do this, if necessary, in a follow-up patch.
- With all of this code applied we could use some documentation about
the defconfig file format and how it interacts with the board config files. This could come from your commit messages perhaps.
Yes. I can do this after the series is applied. I agree this should be documented.
BTW Python doc strings usually use " instead of ' and :
http://legacy.python.org/dev/peps/pep-0008/#documentation-strings
Uh, thanks. Fixed.
Best Regards Masahiro Yamada