Re: [PATCH v2] imx8mm-phg: Add board support

On Tue, Jan 10, 2023 at 09:41:48AM -0300, Fabio Estevam wrote:

Add the board support for the i.MX8MM Cloos PHG board.

This board uses a imx8mm-tqma8mqml SoM from TQ-Group.

imx8mm-phg.dts and imx8mm-tqma8mqml.dtsi are taken directly from Linux 6.2-rc3.

Signed-off-by: Fabio Estevam festevam@denx.de

Changes since v1:

• Rebased on top of current master (Tom)
• Converted doc to rst format (Tom)
• Simplified environment

[snip]

+/* Initial environment variables */ +#define CFG_EXTRA_ENV_SETTINGS \

• "console=ttymxc1,115200\0" \
• "fdtfile=imx8mm-phg.dtb\0" \
• "fdt_addr_r=0x43000000\0" \
• "mmcdev=0\0" \
• "mmcargs=setenv bootargs console=${console} root=/dev/mmcblk${mmcdev}p${mmcpart} rw rootwait quiet\0" \
• "bootcmd=env exists mmcpart || setenv mmcpart 1; run mmcargs; \
• mmc dev ${mmcdev}; load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/Image; \
• load mmc ${mmcdev}:${mmcpart} ${fdt_addr_r} boot/${fdtfile}; \
• booti ${loadaddr} - ${fdt_addr_r}\0"

We're not yet to the point of nak'ing new boards over this, but if you look at something like board/kontron/sl-mx8mm/sl-mx8mm.env the above is trivially done that way instead. Is there something blocking doing that?