Re: [U-Boot] [PATCH] New QorIQ p1020 based board support from Arcturus Networks Inc.

Oleks,

I suggest to change the subject to "powerpc/mpc85xx: Add board support for ucp1020".

On 04/15/2015 12:37 PM, Oleksandr G Zhadan wrote:

New QorIQ p1020 based board support from Arcturus Networks Inc. http://www.arcturusnetworks.com/products/ucp1020/

Signed-off-by: Michael Durrant mdurrant@arcturusnetworks.com Signed-off-by: Oleksandr G Zhadan oleks@arcturusnetworks.com

---

<snip>

+int get_arc_info(void) +{

• int location = 1;
• flash = spi_flash_probe(CONFIG_ENV_SPI_BUS, CONFIG_ENV_SPI_CS,

• 		CONFIG_ENV_SPI_MAX_HZ, CONFIG_ENV_SPI_MODE);
  

• if (spi_flash_read(flash, (0x200 - sizeof(smac)), sizeof(smac), smac)) {

• location++;
  

• if (spi_flash_read(flash, (0x400 - sizeof(smac)), sizeof(smac), smac)) {
  

• 	location++;
  

• 	if (spi_flash_read(flash, (CONFIG_ENV_SECT_SIZE + 0x200 - sizeof(smac)), sizeof(smac), smac)) {
  

• 		location++;
  

• 		if (spi_flash_read(flash, (CONFIG_ENV_SECT_SIZE + 0x400 - sizeof(smac)), sizeof(smac), smac)) {
  

• 			printf("%s: ERROR: Failed to read all %d factory info spi locations\n", __func__, location);
  

These lines are way too long. Please wrap them back at or before 80 characters. You can keep printf string in one line, but the arguments should be in next.

There are many lines over 80 characters. Please try to fix all.

York