24 Jun
2012
24 Jun
'12
3:08 p.m.
Dear Wolfgang Denk,
Dear Otavio Salvador,
In message 1340482108-18468-4-git-send-email-otavio@ossystems.com.br you
wrote:
In case an unidentified CPU type is detected it now returns i.MX<unidentified>, in a const char.
...
-static char *get_imx_type(u32 imxtype) +static const char *get_imx_type(u32 imxtype)
I agree with the const change.
return "unknown";
return "<unidentified>";But in which way would "<unidentified>" be better than "unknown"? It just costs 7 more bytes of memory...
"i.MXunknown" is much more weird than "i.MX<unidentified>" . This is on my tap, Otavio is innocent with this one. btw. this would be static data, so adding 7 more bytes won't hurt anyone.
Please drop this change.
Best regards,
Wolfgang Denk
Best regards, Marek Vasut