Re: [U-Boot-Users] [PATCH] Update OMAP242x for git head (plus sign).

In message EA12F909C0431D458B9D18A176BEE4A50246905D@dlee02.ent.ti.com you wrote:

• Patch by Richard Woodruff, 28 Sep 2005:

OMAP242x H4 board update

• Switch to private cfi_flah.c file.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

• Make work for 2422 mono-ddr.
• Make work for 2420-POP.
• Use clock gauging to determine crystal speed.
• Fix warm reset problem with bad OTGCTRL access.
• Switch to DDR unlock mode operation for DLL errata.
• Remove obsolete APTIX conditionals.
• Display more information at startup.
• Use 24XX instead of 2420 in prep for future chips.

I reject this patch. You duplicate the common drivers/cfi_flash.c file (1269 lines) with less than 1% modifications into a board specific file (board/omap2420h4/cfi_flash.c).

This is not acceptable.

Also, your patch is much too big. Please break it down into digestable chunks. Please see the README, and re-read my posting http://sourceforge.net/mailarchive/message.php?msg_id=12658390

In short:

Make separate commits for logically separate changes.

Best regards,

Wolfgang Denk