Re: [U-Boot] [PATCH 31/51] fpga: altera: Make altera_validate return normal values

On Sun 2014-09-21 15:12:12, Marek Vasut wrote:

Make the function return either 0 or -EINVAL, that is, normal expected error codes and success codes instead of true/false nonsense.

Signed-off-by: Marek Vasut marex@denx.de Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@altera.com Cc: Albert Aribaud albert.u.boot@aribaud.net Cc: Tom Rini trini@ti.com Cc: Wolfgang Denk wd@denx.de

Acked-by: Pavel Machek pavel@denx.de

@@ -133,7 +133,7 @@ int altera_info(Altera_desc *desc) { int ret_val = FPGA_FAIL;

• if (!altera_validate (desc, (char *)__func__)) {

• if (altera_validate (desc, (char *)__func__)) {

+ if (altera_validate(desc, (char *)__func__)) {

You have extra space there, checkpatch would be angry. Pavel