Re: [PATCH v5 1/7] usb: onboard-hub: Add reset-gpio support

On 10/7/24 5:03 PM, Abbarapu, Venkatesh wrote:

[...]

...

...

static int usb_onboard_hub_probe(struct udevice *dev) { struct onboard_hub *hub = dev_get_priv(dev); @@ -30,7 +67,11 @@ static int usb_onboard_hub_probe(struct udevice *dev) if (ret) dev_err(dev, "can't enable vdd-supply: %d\n", ret);

• return ret;

• ret = usb_onboard_hub_reset(dev);

return usb_onboard_hub_reset(dev);

<Venkatesh> By adding the "return usb_onboard_hub_reset(dev);" we miss the code which does i2c initialization sequence which is part of [PATCH v4 4/7] usb: onboard-hub: Add i2c initialization for usb5744 hub of the series.

Surely this can be solved in 4/7 ?