On 04.03.24 16:50, Igor Opaniuk wrote:
Hi Ilias,
On Mon, Mar 4, 2024 at 12:16 PM Ilias Apalodimas <ilias.apalodimas@linaro.org mailto:ilias.apalodimas@linaro.org> wrote:
Hi Igor, On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk <igor.opaniuk@gmail.com <mailto:igor.opaniuk@gmail.com>> wrote: > > > - Address some spelling errors and typos > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests > - Remove common.h inclusion for drivers/tee > > Changes in v2: > - Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset' > - Applied R-b and T-b tags https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19808 <https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19808> this seems to have a few failures Cheers /Ilias > > Igor Opaniuk (5): > tee: optee: fix description in Kconfig > tee: sandbox: fix spelling errors > cmd: optee_rpmb: build cmd for sandbox > test: py: add optee_rpmb tests > tee: remove common.h inclusion > > cmd/Kconfig | 4 +++- > drivers/tee/broadcom/chimp_optee.c | 3 ++- > drivers/tee/optee/Kconfig | 2 +- > drivers/tee/optee/core.c | 1 - > drivers/tee/optee/i2c.c | 1 - > drivers/tee/optee/rpmb.c | 1 - > drivers/tee/optee/supplicant.c | 2 +- > drivers/tee/sandbox.c | 10 +++++----- > drivers/tee/tee-uclass.c | 1 - > test/py/tests/test_optee_rpmb.py | 20 ++++++++++++++++++++ > 10 files changed, 32 insertions(+), 13 deletions(-) > create mode 100644 test/py/tests/test_optee_rpmb.py > > -- > 2.34.1 >It looks like it's a side effect, the test I added revealed a bug in "cmd/optee_rpmb.c" implementation, which I didn't touch (looks like it doesn't close the tee session automatically).
I'll address it and add a fix to the patch series.
Just a quick question, are Azure pipelines still used (so I can configure my own account and run all these before sending patches, as explained in [1])
[1] https://docs.u-boot.org/en/latest/develop/ci_testing.html https://docs.u-boot.org/en/latest/develop/ci_testing.html
Yes, Azure CI is in use (see https://github.com/u-boot/u-boot).
Creating a pull request for https://github.com/u-boot/u-boot may be the easier way for a single test run.
Regards
Heinrich