Hi Andre,
On 22 March 2020 5:31:11 AM IST, "André Przywara" andre.przywara@arm.com wrote:
On 21/03/2020 17:30, Amit Singh Tomar wrote:
Hi Mani,
This adds Cubieboard7[1] support based on Action Semi's S700 SoC[2],
It's Quad-core ARMv8 SoC
with Cortex-A53 cores. Peripheral like UART seems to be compatible
with S900 SoC(basic support
for it is alreay present in u-boot).
I reviewed the series and am now happy with it - I added the missing review tags for patch 1 and 9. I find the instructions in the final patch quite convoluted and somewhat cumbersome, but I guess this is more due to the vendor boot process being somewhat closed down.
I have neither hardware, so can't test anything, but at least I compile tested every patch with bubblegum_96_defconfig, and the final patch with cubieboard7_defconfig. I hope that I didn't miss anything that would break the Bubblegum board, but please test it if you have the hardware.
I've been shadowing this series due to not getting enough time for reviewing/testing. I hope to spend time next week on this.
Thanks Amit for your patience and updates.
Regards, Mani
Amit, thanks for your continued work on this and the prompt replies!
Cheers, Andre
This series(v8) removes the SoC specific include instead just uses
owl-common. For this
patch 01/12 and 09/12 changes a bit.
Previous series(v7) fixes a serious Bug that breaks S900, it was
there since v5.Thanks to Andre
for pointing it out.
Series(v6)[3] does following changes:
- [PATCH v5 06/11] becomes [PATCH v6 03/11]
- [PATCH v5 03/11] becomes [PATCH v6 04/11]
- Introduce a new patch to move defconfig options to Kconfig which is
[PATCH v6 10/12]
Series(v5)[4] just re-orders the patches so that U-BOOT(with
bubblegum96_defconfig) builds
after every patch of the series(suggested by Andre).
S700 support is tested[5] on Cubieboard7 board and S900 support is
just compiled tested.
This patch series can be tested using below tree: https://github.com/Atomar25/u-boot/commits/s700_v8
[3]:
http://u-boot.10912.n7.nabble.com/PATCH-v6-00-12-Actions-S700-SoC-support-td...
[4]:
http://u-boot.10912.n7.nabble.com/PATCH-v5-00-11-Actions-S700-SoC-support-td...
Amit Singh Tomar (12): arm: actions: Add common framework for Actions Owl Semi SoCs arm: actions: rename sysmap-s900 to sysmap-owl serial: actions: add compatible string arm: dts: sync dts for Action Semi S900 arm: dts: actions: s900: add u-boot specific dtsi file clk: actions: Add common clock driver arm: actions: add S700 SoC device tree arm: dts: actions: s700: add u-boot specific dtsi file arm: add support Actions Semi S700 actions: Move defconfig options to Kconfig arm: add Cubieboard7 board support doc: boards: add Cubieboard7 documentation
MAINTAINERS | 2 + arch/arm/Kconfig | 5 +- arch/arm/dts/Makefile | 6 +- arch/arm/dts/s700-cubieboard7.dts | 92 +++++++ arch/arm/dts/s700-u-boot.dtsi | 18 ++ arch/arm/dts/s700.dtsi | 248
+++++++++++++++++++
arch/arm/dts/s900-u-boot.dtsi | 17 ++ arch/arm/dts/s900.dtsi | 322
+++++++++++++++++++++++--
arch/arm/include/asm/arch-owl/clk_s900.h | 57 ----- arch/arm/include/asm/arch-owl/regs_s700.h | 56 +++++ arch/arm/mach-owl/Kconfig | 50 ++-- arch/arm/mach-owl/Makefile | 3 +- arch/arm/mach-owl/soc.c | 57 +++++ arch/arm/mach-owl/sysmap-owl.c | 32 +++ arch/arm/mach-owl/sysmap-s900.c | 32 --- board/ucRobotics/bubblegum_96/Kconfig | 15 -- board/ucRobotics/bubblegum_96/MAINTAINERS | 6 - board/ucRobotics/bubblegum_96/Makefile | 3 - board/ucRobotics/bubblegum_96/bubblegum_96.c | 57 ----- configs/bubblegum_96_defconfig | 12 +- configs/cubieboard7_defconfig | 9 + doc/board/actions/cubieboard7.rst | 115 +++++++++ doc/board/actions/index.rst | 10 + doc/board/index.rst | 1 + drivers/clk/owl/Kconfig | 8 +- drivers/clk/owl/Makefile | 2 +- drivers/clk/owl/clk_owl.c | 153 ++++++++++++ drivers/clk/owl/clk_owl.h | 65 +++++ drivers/clk/owl/clk_s900.c | 137 ----------- drivers/serial/serial_owl.c | 2 +- include/configs/bubblegum_96.h | 40 --- include/configs/owl-common.h | 40 +++ include/configs/s700.h | 13 + include/configs/s900.h | 16 ++ include/dt-bindings/clock/actions,s700-cmu.h | 118 +++++++++ include/dt-bindings/clock/actions,s900-cmu.h | 129 ++++++++++ include/dt-bindings/clock/s900_cmu.h | 77 ------ include/dt-bindings/reset/actions,s700-reset.h | 34 +++ include/dt-bindings/reset/actions,s900-reset.h | 65 +++++ 39 files changed, 1638 insertions(+), 486 deletions(-) create mode 100644 arch/arm/dts/s700-cubieboard7.dts create mode 100644 arch/arm/dts/s700-u-boot.dtsi create mode 100644 arch/arm/dts/s700.dtsi create mode 100644 arch/arm/dts/s900-u-boot.dtsi delete mode 100644 arch/arm/include/asm/arch-owl/clk_s900.h create mode 100644 arch/arm/include/asm/arch-owl/regs_s700.h create mode 100644 arch/arm/mach-owl/soc.c create mode 100644 arch/arm/mach-owl/sysmap-owl.c delete mode 100644 arch/arm/mach-owl/sysmap-s900.c delete mode 100644 board/ucRobotics/bubblegum_96/Kconfig delete mode 100644 board/ucRobotics/bubblegum_96/MAINTAINERS delete mode 100644 board/ucRobotics/bubblegum_96/Makefile delete mode 100644 board/ucRobotics/bubblegum_96/bubblegum_96.c create mode 100644 configs/cubieboard7_defconfig create mode 100644 doc/board/actions/cubieboard7.rst create mode 100644 doc/board/actions/index.rst create mode 100644 drivers/clk/owl/clk_owl.c create mode 100644 drivers/clk/owl/clk_owl.h delete mode 100644 drivers/clk/owl/clk_s900.c delete mode 100644 include/configs/bubblegum_96.h create mode 100644 include/configs/owl-common.h create mode 100644 include/configs/s700.h create mode 100644 include/configs/s900.h create mode 100644 include/dt-bindings/clock/actions,s700-cmu.h create mode 100644 include/dt-bindings/clock/actions,s900-cmu.h delete mode 100644 include/dt-bindings/clock/s900_cmu.h create mode 100644 include/dt-bindings/reset/actions,s700-reset.h create mode 100644 include/dt-bindings/reset/actions,s900-reset.h