Dear Lukasz Majewski,
In message 1309870396-26363-1-git-send-email-l.majewski@samsung.com you wrote:
Included commits provide Linux USB gadget support for U-boot. The USB Gadget infrastructure is running on top of the Samsung's UDC OTG controller. The code has been tested on the GONI (S5PC110) reference target.
What about the other architectures / SoCs?
Aren't passing the checkpatch.pl script check, however they were taken from Linux kernel. On purpose this code hasn't been corrected, to facilitate further code porting from Linux to U-boot (or in opposite direction)
Why don't you provide reference then in the patches? See bullet # 4 at http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign
Are these really unchanged files, or what exactly did you change?
And why do you even violate coding style inthe lines that you did change? for example, I'm pretty sure that this was changed by you:
WARNING: space prohibited between function name and open parenthesis '(' #222: FILE: common/cmd_usb_mass_storage.c:14: +#define UMS_DBG(fmt,args...) printf (fmt ,##args)
ERROR: space required after that ',' (ctx:VxV) #222: FILE: common/cmd_usb_mass_storage.c:14: +#define UMS_DBG(fmt,args...) printf (fmt ,##args) ^
ERROR: space required after that ',' (ctx:WxV) #222: FILE: common/cmd_usb_mass_storage.c:14: +#define UMS_DBG(fmt,args...) printf (fmt ,##args) ^
Best regards,
Wolfgang Denk