Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations

Dear Guennadi Liakhovetski,

In message Pine.LNX.4.64.0808311757460.3747@axis700.grange you wrote:

So, no, this is not because I didn't like somebody else's coding style. This is because with NAND addition this function would become an absolutely unreadable monster. So, I would consider this patch a readability improvement.

But you are duplicating code. It may be just 20 lines or so, but the better approach would be to leave the common code as is and factor out two new functions being called from the common code.

Best regards,

Wolfgang Denk