Am 26.02.2016 um 09:29 schrieb Michal Simek michal.simek@xilinx.com:
On 26.2.2016 01:49, Alexander Graf wrote:
On 23.02.16 14:07, Michal Simek wrote: Hi,
before I comment the rest. You need to also fix gem driver because it is using 1MB mapping.
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index b3821c31a91d..cf1376ce1bd7 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -150,10 +150,10 @@ struct emac_bd { };
#define RX_BUF 32 -/* Page table entries are set to 1MB, or multiples of 1MB
- (not < 1MB). driver uses less bd's so use 1MB bdspace.
+/* Page table entries are set to 2MB, or multiples of 2MB
- (not < 2MB). driver uses less bd's so use 2MB bdspace.
*/ -#define BD_SPACE 0x100000 +#define BD_SPACE 0x200000 /* BD separation space */ #define BD_SEPRN_SPACE (RX_BUF * sizeof(struct emac_bd))
Looks like I didn't reply to this before. The change above makes a lot of space, but is not required for this patch set. We simply break the page table down to 4k maps.
Unfortunately 1MB can be divided by 4k pages but with the v1 series I was testing this driver stopped to work.
Could you please give v4 a try? I fixed a bunch of bugs in the splitting in between.
Alex