Re: [PATCH 4/7] ARM: dts: at91: sam9x60: Add missing pinctrl node properties

On 1/27/25 12:09, Manikandan Muralidharan wrote:

Add the missing properties for the pinctrl node and for its corresponding GPIO bank nodes to align with the Linux DT.

Signed-off-by: Manikandan Muralidharan manikandan.m@microchip.com

arch/arm/dts/sam9x60.dtsi | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi index 47b65d0ef56..a45e346d4ab 100644 --- a/arch/arm/dts/sam9x60.dtsi +++ b/arch/arm/dts/sam9x60.dtsi @@ -212,43 +212,64 @@ pinctrl: pinctrl@fffff400 { #address-cells = <1>; #size-cells = <1>;

• 		compatible = "microchip,sam9x60-pinctrl", "simple-bus";
  

• 		compatible = "microchip,sam9x60-pinctrl", "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
  

I don't see this compatible in Linux DT.

		ranges = <0xfffff400 0xfffff400 0x800>;
		reg = <0xfffff400 0x200		/* pioA */
		       0xfffff600 0x200		/* pioB */
		       0xfffff800 0x200		/* pioC */
		       0xfffffa00 0x200>;	/* pioD */

• 		/* mux-mask corresponding to sam9x60 SoC in TFBGA228L package */
  

• 		atmel,mux-mask = <
  

• 				  /*     A       B       C       */
  

• 				  0xffffffff 0xffe03fff 0xef00019d       /* pioA */
  

• 				  0x03ffffff 0x02fc7e7f 0x00780000       /* pioB */
  

• 				  0xffffffff 0xffffffff 0xf83fffff       /* pioC */
  

• 				  0x003fffff 0x003f8000 0x00000000       /* pioD */
  

• 				  >;
  };
  
  pioA: gpio@fffff400 {
  	compatible = "atmel,at91sam9x5-gpio", "atmel,at91rm9200-gpio";
  	reg = <0xfffff400 0x200>;
  

• 		interrupts = <2 IRQ_TYPE_LEVEL_HIGH 1>;
  	#gpio-cells = <2>;
  	gpio-controller;
  

• 		interrupt-controller;
  

• 		#interrupt-cells = <2>;
  	clocks = <&pmc PMC_TYPE_PERIPHERAL 2>;
  };
  
  pioB: gpio@fffff600 {
  	compatible = "atmel,at91sam9x5-gpio", "atmel,at91rm9200-gpio";
  	reg = <0xfffff600 0x200>;
  

• 		interrupts = <3 IRQ_TYPE_LEVEL_HIGH 1>;
  	#gpio-cells = <2>;
  	gpio-controller;
  

• 		interrupt-controller;
  

• 		#interrupt-cells = <2>;
  	clocks = <&pmc PMC_TYPE_PERIPHERAL 3>;
  };
  
  pioC: gpio@fffff800 {
  	compatible = "atmel,at91sam9x5-gpio", "atmel,at91rm9200-gpio";
  	reg = <0xfffff800 0x200>;
  

• 		interrupts = <4 IRQ_TYPE_LEVEL_HIGH 1>;
  	#gpio-cells = <2>;
  	gpio-controller;
  

• 		interrupt-controller;
  

• 		#interrupt-cells = <2>;
  	clocks = <&pmc PMC_TYPE_PERIPHERAL 4>;
  };
  
  pioD: gpio@fffffa00 {
  	compatible = "atmel,at91sam9x5-gpio", "atmel,at91rm9200-gpio";
  	reg = <0xfffffa00 0x200>;
  

• 		interrupts = <44 IRQ_TYPE_LEVEL_HIGH 1>;
  	#gpio-cells = <2>;
  	gpio-controller;
  

• 		interrupt-controller;
  

• 		#interrupt-cells = <2>;
  	clocks = <&pmc PMC_TYPE_PERIPHERAL 44>;
  };