Hello Alexey,
On Mon, Jul 8, 2024 at 12:08 PM Alexey Romanov avromanov@salutedevices.com wrote:
Hello, ping.
I ran the CI tests, but they failed once again.
The "Introduce mtdblock device" series fails the "build all 32bit ARM platforms" test and raises "exceeds file size limit" errors like the following:
arm: + mx6sabresd 1056+u-boot.img exceeds file size limit: 1057+ limit: 0xaebf6 bytes 1058+ actual: 0xaef88 bytes 1059+ excess: 0x392 bytes 1060+make[1]: *** [Makefile:1478: u-boot.img] Error 1 1061+make[1]: *** Deleting file 'u-boot.img' 1062+make: *** [Makefile:177: sub-make] Error 2
While the "Introduce UBI block device", applied over the "Introduce mtdblock device" falis the following tests: - vexpress_ca9x4: - xilinx_zynq_virt: - build all 32bit ARM platforms
All with the following error: 1450+arm-linux-gnueabi-ld.bfd: drivers/mtd/ubi/part.o: in function `part_get_info_ubi': 1451+drivers/mtd/ubi/part.c:55:(.text.part_get_info_ubi+0x4c): undefined reference to `__aeabi_ldivmod'
Furthermore the "Introduce mtdblock device" series has to be rebased.
Please, run the buildman tests before submitting the patches.
Thanks and regards, Dario
On Wed, Jun 26, 2024 at 01:44:37PM +0300, Alexey Romanov wrote:
Hello!
This series adds support for the mtdblock device, which allows to read/write data block by block. For example, it can now be used for BCB or Android AB command:
$ bcb load mtd 0 part_name
Tested only on SPI NAND, so bind is made only for SPI NAND drivers.
Changes V1 -> V2 [1]:
- Drop patch [2].
- Add warning if bind NAND mtdblock device.
- Move documentation of mtdblock implementation from commit message to the source code.
- Remove __maybe_unused from mtd partition functions description.
- Use blk_enabled() instead of #ifdefs.
Changes V2 -> V3 [2]:
- Rebased over [3].
- Rename mtd_bread/bwrite -> mtd_blk_read/write.
- Fix GPL-2.0 license short name definiton in headers.
- Add empty line after MTD_ENTRY_NUMBERS define.
Changes V3 -> V4 [4]:
- Fix build warnings: use LBAF printf format string for lbaint_t types.
Changes V4 -> V5 [5]:
- Rebased over u-boot/master.
- Fix build errors and warnings if CONFIG_BLK isn't enabled.
- Fix failed tests in cases is mtdblock device isn't binded.
Changes V5 -> V6 [6]:
- Rebased over u-boot/master.
- Fix build errors when CONFIG_MTD isn't enabled.
- Use auto blk device devnum generation when call blk_create_devicef (pass -1 parameter instead of dev_seq(dev)).
Links:
- [1] https://lore.kernel.org/all/20240227100441.1811047-1-avromanov@salutedevices...
- [2] https://lore.kernel.org/all/20240227100441.1811047-5-avromanov@salutedevices...
- [3] https://lore.kernel.org/u-boot/20240403114047.84030-1-heinrich.schuchardt@ca...
- [4] https://lore.kernel.org/all/20240404105813.1520732-1-avromanov@salutedevices...
- [5] https://lore.kernel.org/all/20240524102920.2631731-1-avromanov@salutedevices...
- [6] https://lore.kernel.org/all/20240603155702.1840464-1-avromanov@salutedevices...
Alexey Romanov (3): disk: support MTD partitions drivers: introduce mtdblock abstraction spinand: bind mtdblock
disk/part.c | 3 +- drivers/block/blk-uclass.c | 1 + drivers/mtd/Kconfig | 1 + drivers/mtd/Makefile | 3 + drivers/mtd/mtdblock.c | 227 ++++++++++++++++++++++++++++++++++++ drivers/mtd/mtdpart.c | 76 ++++++++++++ drivers/mtd/nand/spi/core.c | 20 ++++ include/linux/mtd/mtd.h | 25 ++++ include/part.h | 3 + 9 files changed, 358 insertions(+), 1 deletion(-) create mode 100644 drivers/mtd/mtdblock.c
-- 2.34.1
-- Thank you, Alexey