Re: [U-Boot] [PATCH 1/2] Add support for XZ decompression algorithm.

Dear Luigi 'Comio' Mantellini,

In message 1291562184-27126-1-git-send-email-luigi.mantellini@idf-hit.com you wrote:

XZ (aka LZMA2) is the new version of lzma compression format. The following patch add a cut-down version of XZ Embedded library (v20100702) that supports only single-call API.

In order to enable XZ support, the CONFIG_XZ must be defined by board configuration file.

For any details, please refer to XZ Embedded homesite (http://tukaani.org/xz/embedded.html)

...

@@ -1178,6 +1179,14 @@ The following options need to be configured: then calculate the amount of needed dynamic memory (ensuring the appropriate CONFIG_SYS_MALLOC_LEN value).

• CONFIG_XZ
  

• If this option is set, support for xz compresed
  

• images is included.
  

• XZ format is the next version of LZMA format. See also
  

• the CONFIG_LZMA
  

s/compresed/compressed/

+/*

• • Use the internal CRC32 code instead of kernel's CRC32 module, which
• • is not available in early phase of booting.
• */

+#define XZ_INTERNAL_CRC32 1

This has already caused confusion, but appears to be unused.

Please clean up the code not to contain such dead definitions.

I did not see a reply yet to the request to deprecate CONFIG_LZMA and have the new CONFIG_XZ support handle both .xz and .lzma archives?

Best regards,

Wolfgang Denk