-----Original Message----- From: Michael Trimarchi [mailto:trimarchi@gandalf.sssup.it] Sent: Monday, June 29, 2009 5:48 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c
b/drivers/usb/host/ehci-hcd.c
index bbd547b..7a55638 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device
*dev, unsigned long pipe, void *buffer,
req->requesttype, req->requesttype, le16_to_cpu(req->value), le16_to_cpu(req->index));
- typeReq = req->request << 8 | req->requesttype;
- typeReq = req->request | req->requesttype << 8;
Sorry, but I'm not sure in this inversion. Are your sure?
Hi Michael
I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.
Regards.. Prafulla . .