Hello Dirk,
Dirk Behme wrote:
Heiko Schocher wrote:
Dirk Behme wrote:
[...]
While all above are only style questions, what's about the main functionality topic:
Do we have to call i2c_init() for bus 1 and 2 if switching to it? If yes, who does it? For bus 0 it's already in the code. I'd like that the user doesn't have to care about it. Therefore, I added
I solved this in the multibus_v2 branch, see:
http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus...
Looks like we have to merge that with what is in this patch somehow. What are your plans with that branch? Is it intended to go into mainline, soon?
I have to do some more work, before this is ready to go in mainline...
It seems to me that multibus_v2 and this patch are somehow orthogonal (but yes, they will need some merging).
Yep, I hold the multibus_v2 branch in sync with mainline.
Regarding omap24xx_i2c.c, multibus_v2 seems to deal mainly with the API stuff
http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=blobdiff;f=drivers/i2c/omap24x...
Yep, I adapt this driver only for working with this new API.
while the main part of this patch is to replace all hard coded registers by the ability to switch to an other bus.
I will send an updated patch with fixing at least the review comments, soon.
OK, thanks.
bye Heiko