On Monday, December 28, 2015 at 09:04:55 AM, Thomas Chou wrote:
Hi Marek,
Hi!
On 2015年12月28日 13:35, Marek Vasut wrote:
On Monday, December 28, 2015 at 02:17:46 AM, Thomas Chou wrote:
Hi Marek,
On 2015年12月25日 17:58, Marek Vasut wrote:
On Friday, December 25, 2015 at 09:33:52 AM, Thomas Chou wrote:
Hi Marek,
On 2015年12月25日 12:08, Marek Vasut wrote:
> Well, it is only a putc() which is plain and simple.
Sure, but then I still don't understand why this cannot be in the common code.
Yes, it can be in the common code. Do you have an idea how should it look like?
No, I don't, I am not a CFI expert, sorry.
Then I shall push these first and find way to put it to common code some time later. Thanks.
Is this any way to deal with feedback ? Why don't you put it into flash_erase() for example, in drivers/mtd/cfi_flash.c ?
Though altera-qspi works like CFI flash, it is not CFI flash as it does not have CFI info. It is a separate driver to cfi_flash.c.
Both drivers and many other parallel flash drivers under the board/arch directories are called by common/cmd_flash.c, which is very old and somewhat nasty. It could be the place for common feedback. But this is too far and deeply involved. I wanted to touch it a month ago, made some patches but withdrew then.
I see, thanks for the clarification. OK then.
It'd be nice if you managed to clean that part up eventually :)
Best regards, Marek Vasut