On Sat, Apr 9, 2011 at 2:05 PM, Stefano Babic sbabic@denx.de wrote:
Signed-off-by: Stefano Babic sbabic@denx.de CC: Sandeep Paulraj s-paulraj@ti.com CC: Scott Wood scottwood@freescale.com
[...] @@ -143,20 +144,20 @@ int board_init(void) irq_init(); #endif
-#ifdef CONFIG_NAND_DAVINCI /* * NAND CS setup - cycle counts based on da850evm NAND timings in the * Linux kernel @ 25MHz EMIFA */ +#ifdef CONFIG_NAND_DAVINCI writel((DAVINCI_ABCR_WSETUP(0) |
- DAVINCI_ABCR_WSTROBE(0) |
- DAVINCI_ABCR_WSTROBE(1) |
If WSTROBE is modified then the timings are no longer solely based on the NAND timings in arch/arm/mach-davinci/board-da850-evm.c in the Linux kernel. Can you add an amendment to the comment describing the motivation for the extra WSTROBE cycle?
[...]
Best Regards, Ben Gardiner
--- Nanometrics Inc. http://www.nanometrics.ca