Thanks for the feedback, Heiko!
I will take a look at the new framework...
Michael Burr // Software Engineer II
Logic PD T // 612.436.7273 NOTICE: Important disclaimers and limitations apply to this email. Please see this web page for our disclaimers and limitations: http://logicpd.com/email-disclaimer/
-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Wednesday, September 18, 2013 2:14 AM To: Michael Burr Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] i2c:zynq: I2C multi-bus support on Zynq
Hello Michael,
a "How to send patches", Jagan Teki responded to you, so I only comment your patch ...
Am 17.09.2013 19:29, schrieb Michael Burr:
Zynq PS has two I2C bus masters (called 'I2C0' and 'I2C1'):
Implement 'i2c_set_bus_num' routine to select from these.
Support I2C devices which do not use internal addresses:
Handle case of 'alen == 0' in 'i2c_read', 'i2c_write'.
This supports PCA9548 bus multiplexer on Xilinx ZC702 board. Tested cases of 'alen == 0' and 'alen == 1' on this board. Further minor corrections:
Write 'address' register before 'data' register. Write 'transfer_size' register before 'address' register.
Signed-off-by: Michael Burrmichael.burr@logicpd.com Cc: Albert Aribaudalbert.u.boot@aribaud.net Cc: Heiko Schocherhs@denx.de Cc: Michal Simekmonstr@monstr.eu
drivers/i2c/zynq_i2c.c | 87 ++++++++++++++++++++++++++++++------------------ 1 file changed, 55 insertions(+), 32 deletions(-)
Thanks for your work!
But please use the new i2c multibus/multiadapter framework for adding multibus support for this driver. Currently 4 i2c drivers are ported to this new framework, see:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=880540decfb855e96bc14ac84ac7... http://git.denx.de/?p=u-boot.git;a=commitdiff;h=1f2ba722ac06393d6abe6d473482... http://git.denx.de/?p=u-boot.git;a=commitdiff;h=00f792e0df9ae942427e44595a0f... http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ea818dbbcd59300b56014ac2d677...
You can use them as a base for your work
bye, Heiko