Wolfgang Denk wd@denx.de wrote:
In message 20080508134735.0f777149@hskinnemo-gx620.norway.atmel.com you wrote:
Applied, thanks.
Oh great. We can do API changes without even mentioning it in the change log now?
Did I miss any complaints or NAK against this patch? I didn't see any.
No. I had very limited access to my e-mail during most of April, so I didn't see it until now.
That was version 2 of the patch, so it seems there was opportunity for feedback before? You certainly do not expect me to check each and every piece of code myself. That's why we post patches here - to give you and others a chance for review.
Yeah, I know, I should have complained before. But my main complaint is that API changes are easy to miss when they aren't mentioned in the change log, so I certainly understand if you didn't see it either.
I'd really prefer API changes being posted as separate patches so that they can be discussed separately, and they should _at least_ be mentioned in the change log. Even small, "optional" ones; IMO, u-boot has serious issues with feature creep, so I try to at least put up some resistance whenever I see something that may not have been properly thought through.
Haavard