Dear Marek Vasut,
In message 1366344655-8535-6-git-send-email-marex@denx.de you wrote: ...
+#define CONFIG_CMD_DHCP +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_FAT
One CONFIG_CMD_FAT should be enough.
+#define CONFIG_CMD_I2C +#define CONFIG_CMD_MII +#define CONFIG_CMD_MMC +#define CONFIG_CMD_NAND +#define CONFIG_CMD_NET +#define CONFIG_CMD_PING +#define CONFIG_CMD_SATA +#define CONFIG_CMD_USB
As CONFIG_CMD_DATE is not set, we should enable CONFIG_TIMESTAMP.
+/*
- Ethernet on SOC (FEC)
- */
+#ifdef CONFIG_CMD_NET +#define CONFIG_FEC_MXC +#define CONFIG_ETHPRIME "FEC0"
What would that be good for? We have only a single network interface, so please drop that.
+#define CONFIG_ARP_TIMEOUT 200UL
Is this really needed?
+#define CONFIG_CMDLINE_TAG +#define CONFIG_INITRD_TAG +#define CONFIG_SETUP_MEMORY_TAGS
I think we support only DT enabled kernels, so do we really need these?
+#define CONFIG_BOOTFILE "uImage"
Please make this "m53evk/uImage" as usual.
Don't we need a DT file as well?
+#define CONFIG_BOOTARGS "console=ttymxc1,115200" +#define CONFIG_BOOTCOMMAND "run bootcmd_net"
Where is "bootcmd_net" defined?
I doubt that this is actually a working environment.
+#define CONFIG_LOADADDR 0x70800000 +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
What do we need CONFIG_LOADADDR for?
+/*
- The 0x1000 offset must be present, otherwise board won't boot.
- The value (IRAM_BASE_ADDR) must be spelled out, otherwise linker won't link.
- */
+#define CONFIG_SPL_TEXT_BASE 0x70008000 +#define CONFIG_SPL_PAD_TO 0x8000 +#define CONFIG_SPL_STACK 0x70004000 +#define CONFIG_SPL_LIBCOMMON_SUPPORT +#define CONFIG_SPL_LIBGENERIC_SUPPORT +#define CONFIG_SPL_SERIAL_SUPPORT +#define CONFIG_SPL_GPIO_SUPPORT
The comment above does not relate to the definitions here. Is it misplaced, or not correct?
Best regards,
Wolfgang Denk