Re: [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages

On Sat, 14 Jan 2012 00:27:34 +0100 David Wagner david.wagner@free-electrons.com wrote:

Also, don't split error messages over several lines as per a coding style exception making them easier to grep.

Signed-off-by: David Wagner david.wagner@free-electrons.com

tools/mkenvimage.c | 41 +++++++++++++++-------------------------- 1 files changed, 15 insertions(+), 26 deletions(-)

Applied to u-boot-staging/agust@denx.de with minor change.

@@ -118,7 +113,7 @@ int main(int argc, char **argv) usage(prg); return EXIT_SUCCESS; case 'V':

• 	printf("%s version %s\n", prg, PLAIN_VERSION);
  

• 	printf("%s version %s\n", argv[0], PLAIN_VERSION);
  return EXIT_SUCCESS;
  

  case ':': fprintf(stderr, "Missing argument for option -%c\n",

I've dropped this hunk, since recently there was a patch to mkenvimage.c converting argv[0] to prg.

Thanks, Anatolij