The reset function sets the pin to 0 then 1 but if the pin is marked ACTIVE_LOW in the DT it gets inverted and leaves the TPM in reset. Let the gpio driver take care of the reset polarity.
Signed-off-by: Kayla Theil kayla.theil@mixed-mode.de --- drivers/tpm/tpm2_tis_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c index 7186c179d1..3d105fddba 100644 --- a/drivers/tpm/tpm2_tis_spi.c +++ b/drivers/tpm/tpm2_tis_spi.c @@ -596,9 +596,9 @@ static int tpm_tis_spi_probe(struct udevice *dev) log(LOGC_NONE, LOGL_NOTICE, "%s: missing reset GPIO\n", __func__); } else { - dm_gpio_set_value(&reset_gpio, 0); - mdelay(1); dm_gpio_set_value(&reset_gpio, 1); + mdelay(1); + dm_gpio_set_value(&reset_gpio, 0); } }