Hi Simon,
On 06/29/2016 12:28 PM, Simon Glass wrote:
Hi Jaehoon,
On 27 June 2016 at 23:52, Jaehoon Chung jh80.chung@samsung.com wrote:
There are no places to call these functions. It should be used the callback function. Then it can be used as static functions.
Signed-off-by: Jaehoon Chung jh80.chung@samsung.com
drivers/mmc/dw_mmc.c | 4 ++-- include/dwmmc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 3411f95..f83a6bc 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -182,7 +182,7 @@ static int dwmci_set_transfer_mode(struct dwmci_host *host, }
#ifdef CONFIG_DM_MMC_OPS -int dwmci_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
From what I can see this is already static. Which commit are you basing off?
I'm checking with your 'blk-working' branch. I'm not sure what's correct.
commit dee390a1250c17a4e71e359d6e461319a7cdea54 Author: Simon Glass sjg@chromium.org Date: Sat Jun 11 19:01:49 2016 -0600
dm: blk: Enable CONFIG_BLK if DM_MMC is enabled
If i need to work with other branch, let me know,plz. I have tested the DM with dw_mmc_exynos.c. (It's working fine.)
I will send the patch-set for exynos dwmmc and sdhci controller. So i need to know which repository and branch are correct. :)
Then it's helpful to me for working dm. I think that i can help you for checking on mmc side with DM.
Best Regards, Jaehoon Chung
+static int dwmci_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, struct mmc_data *data) { struct mmc *mmc = mmc_get_mmc_dev(dev); @@ -381,7 +381,7 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq) }
#ifdef CONFIG_DM_MMC_OPS -int dwmci_set_ios(struct udevice *dev) +static int dwmci_set_ios(struct udevice *dev) { struct mmc *mmc = mmc_get_mmc_dev(dev); #else diff --git a/include/dwmmc.h b/include/dwmmc.h index 164d1dc..d18ec84 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -295,9 +295,6 @@ int add_dwmci(struct dwmci_host *host, u32 max_clk, u32 min_clk);
#ifdef CONFIG_DM_MMC_OPS /* Export the operations to drivers */ -int dwmci_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
struct mmc_data *data);-int dwmci_set_ios(struct udevice *dev); int dwmci_probe(struct udevice *dev); extern const struct dm_mmc_ops dm_dwmci_ops;
#endif
1.9.1
Regards, Simon