Dear Gary Jennejohn,
In message 20080915104647.79c73006@peedub.jennejohn.org you wrote:
Sorry, but this doesn't work. If you split patches, you have to do it in an orthogoanl way, such that each patch on it's own makes sense.
That should read "orthogonal", of course.
This patch doesn't make any sense as is. Maybe theree are parts missing that may be buried somewhere in some other patch, but please do not expect that we will try to find them.
Please read this again. Patches must be self-contained. You cannot submit a patch which contains only one half of the modification, while some other important parts are in some other, unrelated patch.
Please re-split patches such that they are independent of each other (except maybe that one has to be applied first), and make sure that each patch is complete in itself.
I did it this way because I didn't want to send the net custodian an unnecessary patch. I though that was the way patches were supposed to be handled. I know I've had complaints from custodians in the past about this.
A consistent policy certainly would be nice.
The policiy is clear and consistent:
Patches should always contain exactly one complete logical change, i. e. * Changes that contain different, unrelated modifications shall be submitted as separate patches, one patch per changeset. * If one logical set of modifications affects or creates several files, all these changes shall be submitted in a single patch.
See http://www.denx.de/wiki/U-Boot/Patches
It's bullet 2 that applies here.
Best regards,
Wolfgang Denk