Hi Michal,
On Wed, Oct 25, 2023 at 09:29:04AM +0200, Michal Simek wrote:
On 10/25/23 07:14, AKASHI Takahiro wrote:
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose.
Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Etienne Carriere etienne.carriere@foss.st.com
v3
- describe that arguments are in hex at a help message
- modify the code for dynamically allocated agent names
v2
- remove sub command category, 'scmi base', for simplicity
cmd/Kconfig | 9 ++ cmd/Makefile | 1 + cmd/scmi.c | 335 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 345 insertions(+) create mode 100644 cmd/scmi.c
diff --git a/cmd/Kconfig b/cmd/Kconfig index 205df2f1fb65..c940051eba91 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -2550,6 +2550,15 @@ config CMD_CROS_EC a number of sub-commands for performing EC tasks such as updating its flash, accessing a small saved context area and talking to the I2C bus behind the EC (if there is one).
+config CMD_SCMI
- bool "Enable scmi command"
- depends on SCMI_FIRMWARE
- default n
As I said in previous email. default n should be removed. It is default option.
I see. I hope that Tom will take care of that when merging if there is no other comment.
-Takahiro Akashi
You can take a look at least on this commit.
commit b4c2c151b14b59a2403675526adf666710cade67 Author: Michal Simek michal.simek@amd.com AuthorDate: Fri Aug 27 08:48:10 2021 +0200 Commit: Tom Rini trini@konsulko.com CommitDate: Tue Aug 31 17:47:49 2021 -0400
Kconfig: Remove all default n/no options default n/no doesn't need to be specified. It is default option anyway. Signed-off-by: Michal Simek <michal.simek@xilinx.com> [trini: Rework FSP_USE_UPD portion] Signed-off-by: Tom Rini <trini@konsulko.com>I have also sent one more resync patch and CC you there too.
Thanks, Michal