On Sunday, August 16, 2015 at 02:34:20 AM, Marcel Ziswiler wrote:
On Wed, 2015-08-12 at 13:43 -0500, Andrew Ruder wrote:
Cc: Marek Vasut marex@denx.de Cc: Heiko Schocher hs@denx.de Signed-off-by: Andrew Ruder andrew.ruder@elecsyscorp.com
This driver was written before the driver model stuff was really around (or at least based on a U-Boot version that only had very preliminary support) so there might be some older conventions in use here. I have tested on a PXA270 board running upstream master with this driver, however - so to some extent this all still works fine. Let me know if things need to change to be accepted, and I'll try to find some time to update!
Apart from the missing commit message.
Signed-off-by: Marcel Ziswiler marcel@ziswiler.com
I think you're misunderstanding the meaning of a SoB line here, the SoB line is a certificate of origin. You didn't write the driver and/or you didn't make changes to it, so you don't place your certificate on it :)
Tested-by: Marcel Ziswiler marcel@ziswiler.com
This one is of course good.
Tested-on: Colibri PXA270 V1.2C, V1.2D, V2.2B, V2.4A on Colibri
Is this some kind of a newly invented tag ? :-)
Evaluation Board V3.1A Note: While power I2C works on the older V1.2C version it does not seem to work on any of the newer ones but this might just be a pin muxing resp. missing pull up issue.
Very nice. Btw. how do you bootstrap those modules, do you use that OpenPXA OBM or OBM2 or something else entirely ?
Best regards, Marek Vasut