Hi Takahiro,
On Sun, 19 Dec 2021 at 19:38, AKASHI Takahiro takahiro.akashi@linaro.org wrote:
On Fri, Dec 17, 2021 at 09:37:21AM -0700, Simon Glass wrote:
Hi Heinrich,
On Thu, 9 Dec 2021 at 13:27, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 12/4/21 07:56, Simon Glass wrote:
At present the 'efi' command only works in the EFI payload. Update it to work in the app too, so the memory map can be examined.
cmd/efi.c seems to be duplicating function do_efi_show_memmap(). In a future patch we should try to move to using common code for commands efi and efidebug.
Yes and that depends on EFI_LOADER. Perhaps one day we can have a common helper for this, e.g. in lib/efi ?
It will inevitably means that we should stick to *UEFI* interfaces (not EFI_LOADER's internal interfaces like efi_xxx_yyy()) to implement those commands, including most of efidebug subcommands.
That seems right to me, although of course there may be some 'inside knowledge' for some subcommands.
Regards, Simon